Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Staging and Polyfills #317

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Fix: Staging and Polyfills #317

merged 2 commits into from
Apr 13, 2022

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Apr 13, 2022 •
edited
Loading

Description

  • Fixes Buffer not found error,
  • Removes the need for polyfills using solution from this comment

Task: APP-118

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@githubdoramon githubdoramon merged commit 011b181 into develop Apr 13, 2022
@githubdoramon githubdoramon deleted the fix/staging branch April 13, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepehr2github sepehr2github sepehr2github approved these changes

@githubdoramon githubdoramon githubdoramon approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
web-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fabricevladimir @githubdoramon @sepehr2github