Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truffle migration async scripts #366

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix truffle migration async scripts #366

merged 1 commit into from
Jul 24, 2018

Conversation

mnaamani
Copy link
Contributor

Solves #365 using the pattern seen here: trufflesuite/truffle#501

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sohkai
Copy link
Contributor

sohkai commented Jul 24, 2018

Thanks @mnaamani, it looks like this was working for us out of luck, or something with how node timeouts.

The new migration logs look much better (was always puzzled before why they seemed to be out of order).

Will have to remember this trick for our other migrations.

@sohkai sohkai merged commit e98b67c into aragon:dev Jul 24, 2018
@sohkai sohkai mentioned this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants