Skip to content

Commit

Permalink
Minor edits
Browse files Browse the repository at this point in the history
  • Loading branch information
brickpop committed Oct 31, 2024
1 parent 6b9f13d commit 15ee37e
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,36 +100,36 @@ Check the available make targets to simulate and deploy the smart contracts:
### Deployment Checklist

- [ ] I have cloned the official repository on my computer and I have checked out the corresponding branch
- [ ] I am running on a docker container running Debian Linux (stable)
- [ ] I am using the latest official docker engine, running a Debian Linux (stable) image
- [ ] I have run `docker run --rm -it -v .:/deployment debian:bookworm-slim`
- [ ] I have run `apt update && apt install -y make curl git vim neovim bc`
- [ ] I have run `curl -L https://foundry.paradigm.xyz | bash`
- [ ] I have run `source /root/.bashrc && foundryup`
- [ ] I have run `cd /deployment`
- [ ] I have run `make init`
- [ ] I have printed the contents of `.env` and `.env.test` on the screen
- [ ] I am opening an editor on the `/deployment` folder, within Docker
- [ ] I am opening an editor on the `/deployment` folder, within the Docker container
- [ ] The `.env` file contains the correct parameters for the deployment
- [ ] I have created a brand new burner wallet and copied the private key to `DEPLOYMENT_PRIVATE_KEY`
- [ ] I have created a brand new burner wallet with `cast wallet new` and copied the private key to `DEPLOYMENT_PRIVATE_KEY` within `.env`
- [ ] I have reviewed the target network and RPC URL
- [ ] I have checked that the JSON file under `MULTISIG_MEMBERS_JSON_FILE_NAME` contains the correct list of addresses
- [ ] I have checked that the JSON file under `MULTISIG_MEMBERS_JSON_FILE_NAME` contains the correct list of signers
- [ ] I have ensured all multisig members have undergone a proper security review and are aware of the security implications of being on said multisig
- [ ] I have checked that `MIN_APPROVALS` and `MULTISIG_PROPOSAL_EXPIRATION_PERIOD` are correct
- [ ] I have checked
- [ ] I have verified that `TOKEN1_ADDRESS` corresponds to an ERC20 contract on the target chain (same for TOKEN2 if applicable)
- [ ] I have checked that `VE_TOKEN1_NAME` and `VE_TOKEN1_SYMBOL` are correct (same for TOKEN2 if applicable)
- I have checked that fee percent, warmup period, cooldown period, min lock duration, and min deposit:
- [ ] Have the expected values
- [ ] Cannot leave the voting contract or user tokens locked
- [ ] Cannot leave the voting contract or user tokens locked out
- [ ] I have checked that `VOTING_PAUSED` is true, should voting not be active right away
- [ ] The multisig plugin repo and version:
- [ ] Correspond to the official contract on the target network
- [ ] Point to the latest stable release available
- The plugin ENS subdomain
- [ ] Contains a meaningful and unique value
- The OSx addresses:
- The given OSx addresses:
- [ ] Exist on the target network
- [ ] Contain the latest stable official version of the OSx DAO implementation, the Plugin Setup Processor and the Plugin Repo Factory
- [ ] I have verified the values on https://www.npmjs.com/package/@aragon/osx-commons-configs?activeTab=code > `/@aragon/osx-commons-configs/dist/deployments/json/`
- [ ] I have updated the `CurveConstantLib` and `Clock` with any new constants.
- [ ] All my unit tests pass (`make test`)
- **Target test network**
Expand Down

0 comments on commit 15ee37e

Please sign in to comment.