Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap slow tests in a SLOW_TESTS env var when running on remote DynamoDB #172

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

ryanblock
Copy link
Member

Thank you for helping out! ✨

We really appreciate your commitment to improving Dynalite

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

@ryanblock
Copy link
Member Author

Diffing on this looks super weird, it's like a ~20loc change where I just wrapped previously skipped tests in a condition of using the SLOW_TESTS env var when REMOTE is set.

@ryanblock ryanblock merged commit a9576b4 into main Aug 31, 2023
20 checks passed
@ryanblock ryanblock deleted the slow-tests branch August 31, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant