Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.5] Sending a Packet S2C Disconnects Client from Dedicated Server on NeoForge #498

Closed
hammy275 opened this issue Apr 28, 2024 · 0 comments
Closed

[1.20.5] Sending a Packet S2C Disconnects Client from Dedicated Server on NeoForge #498

hammy275 opened this issue Apr 28, 2024 · 0 comments
Assignees
@Jab125
Labels
priority: high This needs to be worked on and reviewed ASAP

Comments

@hammy275
Copy link

Basically what the title says. On a dedicated server only (singleplayer server is fine), sending a packet from server to client disconnects the client and puts an error in the server log (link to server log). This occurs under NeoForge, however I can't attempt to reproduce this under Fabric due to #496 (perhaps S2C packets also cause the same issue? Not sure). From what I can gather, C2S packet sends under NeoForge are totally fine.

I've made a very minimal mod that reproduces the issue, with an included build for NeoForge.
@Jab125 Jab125 self-assigned this Apr 29, 2024
@Jab125 Jab125 added the priority: high This needs to be worked on and reviewed ASAP label Apr 29, 2024
Jab125 added a commit to Jab125/architectury-api that referenced this issue Apr 29, 2024
@Jab125
Fix architectury#498
ec942d6
Jab125 added a commit to Jab125/architectury-api that referenced this issue Apr 29, 2024
@Jab125
Add test for architectury#498
9a39a81
@Jab125 Jab125 mentioned this issue Apr 29, 2024
Merged
Jab125 added a commit to Jab125/architectury-api that referenced this issue Apr 29, 2024
@Jab125
Add test for architectury#498
df7a0ca
shedaniel pushed a commit that referenced this issue Apr 29, 2024
@Jab125
Fix breakage in NeoForge 20.5.14, fix crash when registering packets …
02c89ba 
…on Fabric, fix players getting kicked when a S2C packet is sent to them. (#499)

* Fix #497

* Fix #496

* Fix #498

* Add test for #498

* Update architectury.mixins.json
@Jab125 Jab125 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jab125 Jab125

Labels
priority: high This needs to be worked on and reviewed ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hammy275 @Jab125