[4.x] Make forcing RLS configurable #1293
Open
+159
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
============================================
+ Coverage 84.68% 85.04% +0.35%
- Complexity 1036 1067 +31
============================================
Files 175 176 +1
Lines 3043 3163 +120
============================================
+ Hits 2577 2690 +113
- Misses 466 473 +7 ☔ View full report in Codecov by Sentry. |
stancl
reviewed
Jan 14, 2025
stancl
reviewed
Jan 14, 2025
|
Any news on this? <3 |
stancl
reviewed
Feb 5, 2025
Comment on lines
+578
to
+579
| // The table owner should see all the records | ||
| expect(Order::all())->toHaveCount(2); |
There was a problem hiding this comment.
In this test, add a dataset for $forceRls so the difference is actually observed. Assuming createPostgresUser() creates a user without BYPASSRLS, the change should be simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
$forceRlsstatic property to thetenants:rlscommand.If
$forceRlsistrue(default), the table owners won't be able to query their own tables (unless the owners have the BYPASSRLS privilege). If the property is set tofalse, table owners will bypass RLS, allowing them to query the owned tables.