Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irremote_full] Save the current status even when sending IR #11188

Closed
wants to merge 1 commit into from

Conversation

nao-pon
Copy link

@nao-pon nao-pon commented Mar 2, 2021

Description:

If the IR transmission is successful, it should save the current status. If it does not notify the current state next time, the toggle function data will be inconsistent.

Related issue (if applicable):
see crankyoldgit/IRremoteESP8266#1424

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

If the IR transmission is successful, it should save the current status. If you do not save the current state and notify it next time, the toggle function data will be inconsistent.

see. crankyoldgit/IRremoteESP8266#1424
@s-hadinger
Copy link
Collaborator

I don't agree with your change that creates a regression with the previous version. Saving the state should depend on stateMode.

We can discuss though of changing the default of stateMode from StateModes::SEND_ONLY to StateModes:: SEND_STORE

@nao-pon
Copy link
Author

nao-pon commented Mar 2, 2021

Yes, I understand. What is the effect of defaulting stateMode to StateModes::SEND_STORE?

@nao-pon
Copy link
Author

nao-pon commented Mar 2, 2021

Looking at the source code, I noticed that SendMode can be modified by the MQTT payload. I would like to withdraw this PR as my wishes can be achieved by it.

Thank you for your support.

@nao-pon nao-pon closed this Mar 2, 2021
@nao-pon nao-pon deleted the patch-2 branch March 2, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants