Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase macOS system requirements to macOS 10.15 #1830

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

jcm93
Copy link
Contributor

@jcm93 jcm93 commented Feb 11, 2025

This is the result of an unfortunate situation where two primary dependencies, MoltenVK and librashader, both require macOS 10.15 at runtime.

In librashader's case, we cannot reasonably target 10.13 due to its glslang dependency, which requires macOS 10.15 at runtime. We could build a highly out-of-date librashader version without glslang, but in doing so we would forfeit various desirable fixes and improvements to librashader.

In MoltenVK's case, the last version with advertised 10.13 support is 1.2.9. In theory, this version should be acceptable for us, since MoltenVK updates rarely directly impact paraLLEl-RDP. However, version 1.2.9 seems to also have a hidden macOS 10.15 requirement due to its own glslang dependency; it is unclear if 1.2.9 actually functions on macOS 10.13 or macOS 10.14. The earliest version that seems to not have any components built against macOS 10.15 is 1.2.6, which is bordering on prohibitively old, and also requires building on both an older version of macOS (13.0) and an older version of Python with the now-defunct distutils package (<3.12).

The ares application itself without dependencies can still be built to target much older versions of macOS (10.13 with a modern toolchain, or macOS 10.10 on an older toolchain), but due to the impact of these dependencies, and the questionable value in shipping an alternate, Intel-only version of ares without dependencies, it has been deemed more appropriate to increment the overall system requirements, at least for official builds.

In builds from source, if CMAKE_OSX_DEPLOYMENT_TARGET is set below the runtime version requirement of our weakly linked dependencies, those weakly linked dependencies will now no longer be included in the app bundle. This enables users wanting to build from source targeting earlier versions of macOS on their own machines to produce working builds more easily.

This PR also fixes some trivial deprecation warnings introduced with a minimum deployment target of 10.15; none of these fixes directly impact system requirements.

@LukeUsher LukeUsher merged commit 4fc0943 into ares-emulator:master Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants