Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Align MSYS2 git line ending settings with system git #1835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcm93
Copy link
Contributor

@jcm93 jcm93 commented Feb 16, 2025

CI checks out code with Windows system Git in C:/Program Files, which has line ending settings that conflict with MSYS2 git, which ends up being used to derive the version information in CMake. The checkout action's git seems to use autocrlf = true, while apparently MSYS2 does not, so MSYS2 git believes all line endings in the project have been changed.

This should resolve the issue of MSYS2 tagged releases having -modified in the version information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant