Update sha256 for Wonder Boy in Monster World (USA, Europe) for proper eeprom assignment #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r eeprom assignment
|
Is there a reason we are using the hash here as opposed to game id like we do for n64? |
|
They don't really have a game id code that is consistent like the N64 which you can trust because Nintendo made sure they were unique and valid. Sega cartridges have a serial number field, but a lot of them seem to be garbage and controlled by the developer. For example, the serial for FIFA 96 (32x) is: "Revision1.0". That's not a real serial Id, it's whatever junk they wanted to put in that field. If there were a real Id assigned, it would be preferred, but we don't have that here. There are also hundreds of entries in this file all based on hash which I would imagine is all for the same reason as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the has value we had for Wonder Boy in Monster World was outdated from the GoodGen era and was not current with the currently agreed dump of this game in No-Intro's DB. This resulted in a hang after pressing start at the main menu as EEPROM values were not being found.
This update the sha256 hash with the currently accepted dump of this game. EEPROM values are now being found and assigned correctly and the game is now playable.