Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge scripts in test/e2e2 and hack/demo-env #244

Closed
jannfis opened this issue Dec 4, 2024 · 1 comment · Fixed by #253
Closed

Merge scripts in test/e2e2 and hack/demo-env #244

jannfis opened this issue Dec 4, 2024 · 1 comment · Fixed by #253
Assignees
Labels
kind/task Tasks, chores, etc

Comments

@jannfis
Copy link
Collaborator

jannfis commented Dec 4, 2024

Is your task related to a problem? Please describe.

Many of the scripts in test/e2e2 and hack/demo-env feel (and probably are) redundant, as they do the same things:

  • Setup a vcluster environment and install Argo CD in various degrees of completeness
  • Start the principal from the current code base
  • Start the agent(s) from the current code base

That makes changes to one or the other cumbersome, and both scripts will slowly drift apart.

Describe the solution you'd like

It would be great if we can use one single set of scripts for both scenarios, e2e tests and the demo env.

Describe alternatives you've considered

n/a

Additional context

n/a

@jannfis jannfis added the kind/task Tasks, chores, etc label Dec 4, 2024
@jopit
Copy link
Contributor

jopit commented Dec 6, 2024

I'll take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Tasks, chores, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants