Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge scripts in test/e2e2 and hack/demo-env #253

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

jopit
Copy link
Contributor

@jopit jopit commented Dec 10, 2024

What does this PR do / why we need it:

Merges the contents of the test-env and demo-env directories into a new directory called dev-env

Which issue(s) this PR fixes:

Fixes #244

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.21%. Comparing base (32caa19) to head (0d4840d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   47.21%   47.21%           
=======================================
  Files          55       55           
  Lines        4882     4882           
=======================================
  Hits         2305     2305           
  Misses       2401     2401           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jopit jopit changed the title Gitops 5988 merge scripts Merge scripts in test/e2e2 and hack/demo-env Dec 10, 2024
@jopit jopit changed the title Merge scripts in test/e2e2 and hack/demo-env chore: Merge scripts in test/e2e2 and hack/demo-env Dec 10, 2024
Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally to setup an environment, and it failed on me:

-> Generate server.secretkey for agent's argocd-secrets
-> Generate admin password for the control plane
Warning: Value 16 is outside of the allowed entropy range, adjusting it.
-> Create Argo CD on control plane
  --> Creating instance in vcluster control-plane
namespace/argocd created
error: trouble configuring builtin PatchTransformer with config: `
path: argocd-secret.yaml
`: unable to parse SM or JSON patch from [path: "argocd-secret.yaml"]
error: trouble configuring builtin PatchTransformer with config: `
path: argocd-secret.yaml
`: unable to parse SM or JSON patch from [path: "argocd-secret.yaml"]
Switched to context "default".

@jannfis
Copy link
Collaborator

jannfis commented Dec 11, 2024

Found the culprit. Apparently, the secret is invalid after generating server.secretkey:

apiVersion: v1
kind: Secret
metadata:
  name: argocd-secret
data:
  admin.password: JDJ5JDA1JFJlOEtrNGlhYURqQWFKdmxSV3J1SWU3bDVtbG8yRlI4dWg5WUc5eDNVSUFtRkFkeVVs
TFVtCg==
  admin.passwordMtime: MjAyNC0xMi0xMVQxNDoyMjo1N1VUQwo=

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution as proposed change.

hack/dev-env/setup-vcluster-env.sh Outdated Show resolved Hide resolved
hack/dev-env/setup-vcluster-env.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@jannfis jannfis merged commit d950aaa into argoproj-labs:main Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge scripts in test/e2e2 and hack/demo-env
3 participants