-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge scripts in test/e2e2 and hack/demo-env #253
Conversation
Signed-off-by: John Pitman <[email protected]>
Signed-off-by: John Pitman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 47.21% 47.21%
=======================================
Files 55 55
Lines 4882 4882
=======================================
Hits 2305 2305
Misses 2401 2401
Partials 176 176 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally to setup an environment, and it failed on me:
-> Generate server.secretkey for agent's argocd-secrets
-> Generate admin password for the control plane
Warning: Value 16 is outside of the allowed entropy range, adjusting it.
-> Create Argo CD on control plane
--> Creating instance in vcluster control-plane
namespace/argocd created
error: trouble configuring builtin PatchTransformer with config: `
path: argocd-secret.yaml
`: unable to parse SM or JSON patch from [path: "argocd-secret.yaml"]
error: trouble configuring builtin PatchTransformer with config: `
path: argocd-secret.yaml
`: unable to parse SM or JSON patch from [path: "argocd-secret.yaml"]
Switched to context "default".
Found the culprit. Apparently, the secret is invalid after generating server.secretkey:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution as proposed change.
Signed-off-by: John Pitman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
What does this PR do / why we need it:
Merges the contents of the
test-env
anddemo-env
directories into a new directory calleddev-env
Which issue(s) this PR fixes:
Fixes #244