Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resend events only for retryable errors #254

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

chetan-rns
Copy link
Collaborator

What does this PR do / why we need it:

  • Check if the error is retryable/transient.
  • Don't send an ACK for retryable errors so that the principal can resend events.

Which issue(s) this PR fixes:

Fixes #243

How to test changes / Special notes to the reviewer:

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.

Project coverage is 46.79%. Comparing base (d950aaa) to head (aa500c4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/kube/client.go 0.00% 50 Missing ⚠️
agent/connection.go 0.00% 12 Missing ⚠️
principal/event.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   47.21%   46.79%   -0.43%     
==========================================
  Files          55       55              
  Lines        4882     4939      +57     
==========================================
+ Hits         2305     2311       +6     
- Misses       2401     2451      +50     
- Partials      176      177       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jannfis jannfis merged commit a9a8f49 into argoproj-labs:main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated deliveries of invalid events
3 participants