Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bootstrap delete #100

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

noam-codefresh
Copy link
Collaborator

  • depend on ApplicationSet from master branch
  • added PreserveResourcesOnDeletion option to appset
  • fix appset->project delete order

* added PreserveResourcesOnDeletion option to appset
* fix appset->project delete order
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #100 (1584372) into main (7dc340a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   57.35%   57.49%   +0.13%     
==========================================
  Files          12       12              
  Lines        2141     2148       +7     
==========================================
+ Hits         1228     1235       +7     
  Misses        834      834              
  Partials       79       79              
Impacted Files Coverage Δ
cmd/commands/common.go 95.91% <100.00%> (+0.14%) ⬆️
cmd/commands/project.go 48.37% <100.00%> (+0.30%) ⬆️
cmd/commands/repo.go 57.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc340a...1584372. Read the comment docs.

@roi-codefresh roi-codefresh merged commit 80ac723 into argoproj-labs:main Jun 15, 2021
@roi-codefresh roi-codefresh deleted the fix_ns branch June 15, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting the bootstrap app hangs while deleting the entire hierarchy
3 participants