Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-ref/sha/tag #107

Merged
merged 9 commits into from
Jun 17, 2021
Merged

fix-ref/sha/tag #107

merged 9 commits into from
Jun 17, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jun 17, 2021
@noam-codefresh noam-codefresh linked an issue Jun 17, 2021 that may be closed by this pull request
getting "failed to build bootstrap manifests" since v0.2.5 #106
Closed
roi-codefresh
roi-codefresh approved these changes Jun 17, 2021
View reviewed changes
cmd/commands/repo.go Outdated Show resolved Hide resolved
pkg/git/repository.go
@@ -160,7 +159,7 @@ func (o *CloneOptions) URL() string {
}

func (o *CloneOptions) Revision() string {
return plumbing.ReferenceName(o.revision).Short()
return o.revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when creating an Argo CD Application, the Source.Revision field will contain this value.

pkg/git/repository.go
return ErrNoRemotes
}

remoteref := fmt.Sprintf("%s/%s", remotes[0].Config().Name, ref)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add some debug msgs here and before the checkout

@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #107 (9916d57) into main (3f70d9e) will decrease coverage by 2.10%.
The diff coverage is 86.16%.

❗ Current head 9916d57 differs from pull request most recent head 99cbb38. Consider uploading reports for the commit 99cbb38 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   57.49%   55.39%   -2.11%     
==========================================
  Files          12       14       +2     
  Lines        2148     2282     +134     
==========================================
+ Hits         1235     1264      +29     
- Misses        834      938     +104     
- Partials       79       80       +1
Impacted Files Coverage Δ
cmd/commands/repo.go 57.50% <33.33%> (-0.09%) ⬇️
pkg/git/repository.go 64.73% <81.57%> (-7.24%) ⬇️
pkg/util/repospec.go 88.07% <88.07%> (ø)
cmd/commands/app.go 45.23% <100.00%> (+0.33%) ⬆️
pkg/application/application.go 59.94% <100.00%> (-0.12%) ⬇️
pkg/util/util.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f70d9e...99cbb38. Read the comment docs.

@noam-codefresh noam-codefresh merged commit c79e942 into argoproj-labs:main Jun 17, 2021
@noam-codefresh noam-codefresh deleted the fix-ref/sha/tag branch June 17, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roi-codefresh roi-codefresh roi-codefresh approved these changes

Assignees

@noam-codefresh noam-codefresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getting "failed to build bootstrap manifests" since v0.2.5
3 participants
@noam-codefresh @roi-codefresh @ATGardner