Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-5155 - gracefully handle repo-not-exist during clone #116

Merged
merged 7 commits into from
Jun 28, 2021

Conversation

noam-codefresh
Copy link
Collaborator

CloneOptions Clone func will now handle both "repository not found" (and create the repo) and "remote repository is empty" (and will just init it locally)

@noam-codefresh noam-codefresh changed the title gracefully handle repo-not-exist during clone CR-5155 - gracefully handle repo-not-exist during clone Jun 24, 2021
@noam-codefresh noam-codefresh marked this pull request as ready for review June 27, 2021 07:44
simplified provider type inference
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #116 (e245115) into main (0a7eff5) will increase coverage by 3.99%.
The diff coverage is 77.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   55.70%   59.69%   +3.99%     
==========================================
  Files          14       14              
  Lines        2298     2258      -40     
==========================================
+ Hits         1280     1348      +68     
+ Misses        938      828     -110     
- Partials       80       82       +2     
Impacted Files Coverage Δ
cmd/commands/project.go 47.95% <0.00%> (-0.43%) ⬇️
cmd/commands/repo.go 62.23% <16.66%> (+4.73%) ⬆️
cmd/commands/app.go 44.41% <27.27%> (-0.82%) ⬇️
cmd/commands/common.go 96.07% <50.00%> (-0.08%) ⬇️
pkg/git/provider_github.go 78.84% <50.00%> (+44.88%) ⬆️
pkg/git/repository.go 81.09% <95.58%> (+15.45%) ⬆️
pkg/application/application.go 59.94% <100.00%> (ø)
pkg/git/provider.go 83.33% <100.00%> (+83.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7eff5...e245115. Read the comment docs.

pkg/git/provider.go Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/repository.go Show resolved Hide resolved
pkg/git/repository.go Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/git/provider_github.go Outdated Show resolved Hide resolved
@roi-codefresh
Copy link
Contributor

@noam-codefresh noam-codefresh self-assigned this Jun 28, 2021
@noam-codefresh noam-codefresh merged commit 3c8be61 into argoproj-labs:main Jun 28, 2021
@noam-codefresh noam-codefresh deleted the CR-5155 branch June 28, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants