Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timeout flag to app create - wait until App is Synced #117

Merged
merged 7 commits into from
Jun 28, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #117 (4e59ae4) into main (3c8be61) will increase coverage by 0.12%.
The diff coverage is 63.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   59.69%   59.82%   +0.12%     
==========================================
  Files          14       14              
  Lines        2258     2295      +37     
==========================================
+ Hits         1348     1373      +25     
- Misses        828      840      +12     
  Partials       82       82              
Impacted Files Coverage Δ
cmd/commands/project.go 47.00% <ø> (-0.95%) ⬇️
cmd/commands/repo.go 62.23% <0.00%> (ø)
cmd/commands/app.go 46.61% <60.00%> (+2.20%) ⬆️
cmd/commands/common.go 96.25% <100.00%> (+0.17%) ⬆️
pkg/git/repository.go 81.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8be61...4e59ae4. Read the comment docs.

cmd/commands/app.go Outdated Show resolved Hide resolved
cmd/commands/app.go Show resolved Hide resolved
cmd/commands/common.go Show resolved Hide resolved
cmd/commands/repo.go Outdated Show resolved Hide resolved
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
pkg/kube/kube.go Outdated Show resolved Hide resolved
@noam-codefresh noam-codefresh merged commit 6ea3c29 into argoproj-labs:main Jun 28, 2021
@noam-codefresh noam-codefresh deleted the CR-5154 branch June 28, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants