Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR-4773 - add repo uninstall command #122

Merged
merged 14 commits into from
Jul 5, 2021
Merged

CR-4773 - add repo uninstall command #122

merged 14 commits into from
Jul 5, 2021

Conversation

noam-codefresh
Copy link
Collaborator

@noam-codefresh noam-codefresh commented Jul 1, 2021 •
edited
Loading

No description provided.

@ATGardner
added repo uninstall command
ed84d75 
still not fully implemented
@noam-codefresh noam-codefresh self-assigned this Jul 1, 2021
@noam-codefresh noam-codefresh changed the title added repo uninstall command CR-4773 - add repo uninstall command Jul 1, 2021
roi-codefresh
roi-codefresh reviewed Jul 2, 2021
View reviewed changes
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
pkg/git/repository.go Show resolved Hide resolved
@noam-codefresh noam-codefresh marked this pull request as ready for review July 4, 2021 14:11
@codecov
Copy link

codecov bot commented Jul 4, 2021 •
edited
Loading

Codecov Report

Merging #122 (ae1a971) into main (0dee45f) will decrease coverage by 0.35%.
The diff coverage is 62.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   59.82%   59.46%   -0.36%     
==========================================
  Files          14       14              
  Lines        2295     2445     +150     
==========================================
+ Hits         1373     1454      +81     
- Misses        840      902      +62     
- Partials       82       89       +7
Impacted Files Coverage Δ
cmd/commands/project.go 46.72% <50.00%> (-0.28%) ⬇️
pkg/git/repository.go 81.17% <50.00%> (+0.07%) ⬆️
cmd/commands/repo.go 60.17% <58.12%> (-2.07%) ⬇️
cmd/commands/app.go 44.97% <100.00%> (-1.65%) ⬇️
cmd/commands/common.go 96.51% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dee45f...ae1a971. Read the comment docs.

roi-codefresh
roi-codefresh approved these changes Jul 5, 2021
View reviewed changes
pkg/kube/kube.go Show resolved Hide resolved
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
pkg/argocd/argocd.go Outdated Show resolved Hide resolved
docs/commands/argocd-autopilot_repo_uninstall.md Show resolved Hide resolved
cmd/commands/repo.go Outdated Show resolved Hide resolved
cmd/commands/repo.go Outdated Show resolved Hide resolved
cmd/commands/repo.go Outdated Show resolved Hide resolved
cmd/commands/repo.go Outdated Show resolved Hide resolved
@noam-codefresh noam-codefresh linked an issue Jul 5, 2021 that may be closed by this pull request
Add an repo uninstall command to argocd-autopilot #42
Closed
@noam-codefresh noam-codefresh merged commit d6eb87f into argoproj-labs:main Jul 5, 2021
@noam-codefresh noam-codefresh deleted the CR-4773 branch July 5, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roi-codefresh roi-codefresh roi-codefresh approved these changes

@oren-codefresh oren-codefresh Awaiting requested review from oren-codefresh

Assignees

@noam-codefresh noam-codefresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an repo uninstall command to argocd-autopilot
3 participants
@noam-codefresh @roi-codefresh @ATGardner