set KUBECONFIG before argocd login #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roi-codefresh
approved these changes
Jul 12, 2021
pkg/argocd/argocd.go
Outdated
| origKubeConfig := os.Getenv("KUBECONFIG") | ||
| defer func() { os.Setenv("KUBECONFIG", origKubeConfig) }() | ||
| if err := os.Setenv("KUBECONFIG", opts.KubeConfig); err != nil { | ||
| return err |
There was a problem hiding this comment.
return a wrapped error here: failed to set KUBECONFIG env var, cause I'm not sure the error returned here would be clear
| Namespace string | ||
| Username string | ||
| Password string | ||
| KubeConfig string |
There was a problem hiding this comment.
what about kube context?
There was a problem hiding this comment.
removed most kube flags (except for timeout, kubeconfig and namespace).
|
/ci |
removed most kube flags
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 59.59% 59.53% -0.06%
==========================================
Files 14 14
Lines 2445 2439 -6
==========================================
- Hits 1457 1452 -5
+ Misses 900 899 -1
Partials 88 88
Continue to review full report at Codecov.
|
roi-codefresh
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.