Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitea as a SCM provider #128

Merged
merged 6 commits into from
Jul 15, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

Copy link
Contributor

@roi-codefresh roi-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! can you please check to see if we need to have a mention of this anywhere in the documentation? Also, lets change the pr name and have it related to an issue :)

@noam-codefresh noam-codefresh linked an issue Jul 14, 2021 that may be closed by this pull request
@noam-codefresh noam-codefresh changed the title CR-5276 Support gitea as a SCM provider Jul 14, 2021
@noam-codefresh noam-codefresh marked this pull request as ready for review July 15, 2021 06:39
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #128 (3827fb2) into main (26c7eea) will increase coverage by 0.15%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   59.53%   59.68%   +0.15%     
==========================================
  Files          14       15       +1     
  Lines        2439     2473      +34     
==========================================
+ Hits         1452     1476      +24     
- Misses        899      908       +9     
- Partials       88       89       +1     
Impacted Files Coverage Δ
pkg/git/provider.go 100.00% <ø> (+16.66%) ⬆️
pkg/git/provider_gitea.go 70.58% <70.58%> (ø)
cmd/commands/repo.go 59.92% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c7eea...3827fb2. Read the comment docs.

@roi-codefresh
Copy link
Contributor

LGTM

@noam-codefresh noam-codefresh merged commit f734d24 into argoproj-labs:main Jul 15, 2021
@noam-codefresh noam-codefresh deleted the CR-5276 branch July 15, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gitea as a SCM provider
3 participants