Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes provider sort order #131

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #131 (15383df) into main (0118a17) will increase coverage by 11.55%.
The diff coverage is 70.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #131       +/-   ##
===========================================
+ Coverage   48.27%   59.82%   +11.55%     
===========================================
  Files          11       15        +4     
  Lines        1707     2474      +767     
===========================================
+ Hits          824     1480      +656     
- Misses        811      906       +95     
- Partials       72       88       +16     
Impacted Files Coverage Δ
cmd/commands/root.go 0.00% <0.00%> (ø)
cmd/commands/version.go 0.00% <ø> (ø)
pkg/util/util.go 0.00% <0.00%> (ø)
pkg/git/provider_github.go 78.84% <50.00%> (+44.88%) ⬆️
cmd/commands/app.go 44.97% <50.27%> (+14.91%) ⬆️
pkg/application/util.go 57.14% <57.14%> (ø)
cmd/commands/project.go 46.72% <57.48%> (-8.86%) ⬇️
pkg/application/application.go 59.94% <63.30%> (+16.98%) ⬆️
cmd/commands/repo.go 60.45% <66.42%> (+5.13%) ⬆️
pkg/git/provider_gitea.go 70.58% <70.58%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e853fd...15383df. Read the comment docs.

@noam-codefresh noam-codefresh merged commit 9ef33bf into argoproj-labs:main Jul 15, 2021
@noam-codefresh noam-codefresh deleted the fix_provider_sort branch July 15, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants