Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save labels in config.json #139

Merged
merged 4 commits into from
Aug 1, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jul 29, 2021
@noam-codefresh noam-codefresh linked an issue Jul 29, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #139 (023b743) into main (7f9c5b1) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   59.82%   60.01%   +0.19%     
==========================================
  Files          15       15              
  Lines        2474     2486      +12     
==========================================
+ Hits         1480     1492      +12     
  Misses        906      906              
  Partials       88       88              
Impacted Files Coverage Δ
cmd/commands/app.go 45.42% <100.00%> (+0.45%) ⬆️
cmd/commands/project.go 47.81% <100.00%> (+1.08%) ⬆️
pkg/application/application.go 60.17% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9c5b1...023b743. Read the comment docs.

@noam-codefresh noam-codefresh marked this pull request as ready for review August 1, 2021 09:44
@roi-codefresh roi-codefresh merged commit 4540b59 into argoproj-labs:main Aug 1, 2021
@roi-codefresh roi-codefresh deleted the config_labels branch August 1, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sending extra key-value pairs to app create
3 participants