Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-7685 Failed installing into a repo sub-directory #206

Merged
merged 5 commits into from
Nov 24, 2021
Merged

CR-7685 Failed installing into a repo sub-directory #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1f8f76
sent the prepared repo FS instead of CloneOpts.FS
rotem-codefresh Nov 23, 2021
4adf24e
change log fix
rotem-codefresh Nov 23, 2021
b5b71c1
revert some changes
rotem-codefresh Nov 24, 2021
459c76e
revert some changes
rotem-codefresh Nov 24, 2021
fe85397
revert
rotem-codefresh Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog:

# v0.2.24
# v0.2.25

### Features
* Added `--context` flag to `repo bootstrap`, `repo uninstall` and `app create`. [#199](https://github.com/argoproj-labs/argocd-autopilot/pull/199)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION=v0.2.24
VERSION=v0.2.25
OUT_DIR=dist

CLI_NAME?=argocd-autopilot
Expand Down
2 changes: 1 addition & 1 deletion cmd/commands/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func RunAppCreate(ctx context.Context, opts *AppCreateOptions) error {
}

if opts.Timeout > 0 {
namespace, err := getInstallationNamespace(opts.CloneOpts.FS)
namespace, err := getInstallationNamespace(repofs)
if err != nil {
return fmt.Errorf("failed to get application namespace: %w", err)
}
Expand Down
6 changes: 3 additions & 3 deletions docs/releases/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ argocd-autopilot version
### Linux and WSL (using curl):
```bash
# download and extract the binary
curl -L --output - https://github.com/argoproj-labs/argocd-autopilot/releases/download/v0.2.24/argocd-autopilot-linux-amd64.tar.gz | tar zx
curl -L --output - https://github.com/argoproj-labs/argocd-autopilot/releases/download/v0.2.25/argocd-autopilot-linux-amd64.tar.gz | tar zx

# move the binary to your $PATH
mv ./argocd-autopilot-* /usr/local/bin/argocd-autopilot
Expand All @@ -32,7 +32,7 @@ argocd-autopilot version
### Mac (using curl):
```bash
# download and extract the binary
curl -L --output - https://github.com/argoproj-labs/argocd-autopilot/releases/download/v0.2.24/argocd-autopilot-darwin-amd64.tar.gz | tar zx
curl -L --output - https://github.com/argoproj-labs/argocd-autopilot/releases/download/v0.2.25/argocd-autopilot-darwin-amd64.tar.gz | tar zx

# move the binary to your $PATH
mv ./argocd-autopilot-* /usr/local/bin/argocd-autopilot
Expand All @@ -47,5 +47,5 @@ When using the Docker image, you have to provide the `.kube` and `.gitconfig` di
docker run \
-v ~/.kube:/home/autopilot/.kube \
-v ~/.gitconfig:/home/autopilot/.gitconfig \
-it quay.io/argoprojlabs/argocd-autopilot:v0.2.24 <cmd> <flags>
-it quay.io/argoprojlabs/argocd-autopilot:v0.2.25 <cmd> <flags>
```