Allow insecure git server #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-codefresh
force-pushed
the
allow-insecure-git-server
branch
from
2d5bd40 to
7967892
Compare
noam-codefresh
commented
Nov 11, 2022
hack/cmd-docs/main.go
Outdated
| @@ -2,7 +2,6 @@ package main | |||
|
|
|||
| import ( | |||
| "io/fs" | |||
| "io/ioutil" | |||
There was a problem hiding this comment.
these are some unrelated lint warning i fixed - deprecation of io/ioutil
noam-codefresh
force-pushed
the
allow-insecure-git-server
branch
4 times, most recently
from
2beeb73 to
3fb1b3c
Compare
danielm-codefresh
approved these changes
Nov 18, 2022
noam-codefresh
force-pushed
the
allow-insecure-git-server
branch
from
3fb1b3c to
66e2f98
Compare
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
copy insecure from cloneOpts to appCloneOpts Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
noam-codefresh
force-pushed
the
allow-insecure-git-server
branch
from
66e2f98 to
652b142
Compare
kim-codefresh
pushed a commit
that referenced
this pull request
Jan 10, 2023
* added support for --git-server-crt * add certificate to argocd cm Signed-off-by: Noam Gal <[email protected]> Signed-off-by: kim-codefresh <[email protected]>
kim-codefresh
pushed a commit
that referenced
this pull request
Jan 10, 2023
* added support for --git-server-crt * add certificate to argocd cm Signed-off-by: Noam Gal <[email protected]> Signed-off-by: kim-codefresh <[email protected]>
kim-codefresh
pushed a commit
that referenced
this pull request
Jan 10, 2023
* added support for --git-server-crt * add certificate to argocd cm Signed-off-by: Noam Gal <[email protected]> Signed-off-by: kim-codefresh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful for on-prem git servers with a self-signed (or otherwise missing or invalid) certificate. add the
--insecure-git-serverflag to skip certificate verification.