Fix-windows-paths #405
Merged
Fix-windows-paths #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will resolve #221 |
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
noam-codefresh
force-pushed
the
fix-windows-paths
branch
from
5d031b1 to
4133b88
Compare
noam-codefresh
commented
Jan 26, 2023
| @@ -306,7 +306,7 @@ func generateProjectManifests(o *GenerateProjectOptions) (projectYAML, appSetYAM | |||
| Revision: o.Revision, | |||
| Files: []argocdv1alpha1.GitFileGeneratorItem{ | |||
| { | |||
| Path: filepath.Join(o.InstallationPath, store.Default.AppsDir, "**", o.Name, "config.json"), | |||
| Path: path.Join(o.InstallationPath, store.Default.AppsDir, "**", o.Name, "config.json"), | |||
There was a problem hiding this comment.
will always use /
roi-codefresh
approved these changes
Jan 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 61.69% 61.64% -0.06%
==========================================
Files 19 19
Lines 3501 3496 -5
==========================================
- Hits 2160 2155 -5
Misses 1236 1236
Partials 105 105
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noam Gal [email protected]