Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace collision #79

Merged
merged 20 commits into from
Jun 6, 2021

Conversation

roi-codefresh
Copy link
Contributor

No description provided.

@noam-codefresh noam-codefresh linked an issue Jun 3, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #79 (da0c53a) into main (0c70bf8) will increase coverage by 3.56%.
The diff coverage is 80.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   49.95%   53.51%   +3.56%     
==========================================
  Files          13       14       +1     
  Lines        2004     2147     +143     
==========================================
+ Hits         1001     1149     +148     
+ Misses        932      922      -10     
- Partials       71       76       +5     
Impacted Files Coverage Δ
cmd/commands/app.go 35.66% <0.00%> (ø)
pkg/fs/fs.go 95.00% <ø> (ø)
pkg/git/provider.go 0.00% <ø> (ø)
pkg/git/provider_github.go 33.96% <ø> (ø)
pkg/git/repository.go 66.19% <ø> (ø)
pkg/util/util.go 0.00% <0.00%> (ø)
pkg/application/util.go 57.14% <57.14%> (ø)
pkg/application/application.go 58.06% <60.52%> (+9.94%) ⬆️
cmd/commands/project.go 47.78% <64.93%> (-5.95%) ⬇️
cmd/commands/repo.go 57.89% <88.31%> (+2.57%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c70bf8...da0c53a. Read the comment docs.

@roi-codefresh roi-codefresh merged commit faf5f2c into argoproj-labs:main Jun 6, 2021
@roi-codefresh roi-codefresh deleted the fix-namespaces branch June 6, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding two applications with the same ns causes sync ping-pong
3 participants