Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local application infer #88

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

roi-codefresh
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #88 (c72143f) into main (68a62b4) will decrease coverage by 0.07%.
The diff coverage is 34.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   53.59%   53.52%   -0.08%     
==========================================
  Files          14       14              
  Lines        2153     2173      +20     
==========================================
+ Hits         1154     1163       +9     
- Misses        924      933       +9     
- Partials       75       77       +2     
Impacted Files Coverage Δ
cmd/commands/project.go 48.07% <0.00%> (ø)
pkg/application/application.go 58.49% <0.00%> (-1.51%) ⬇️
cmd/commands/app.go 35.68% <50.00%> (+0.89%) ⬆️
cmd/commands/repo.go 57.41% <50.00%> (+0.11%) ⬆️
pkg/git/repository.go 62.34% <66.66%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a62b4...c72143f. Read the comment docs.

@roi-codefresh roi-codefresh force-pushed the fix-infer-local-app branch from 3b366c8 to cd2306a Compare June 8, 2021 08:38
@roi-codefresh roi-codefresh merged commit fdd1445 into argoproj-labs:main Jun 8, 2021
@roi-codefresh roi-codefresh deleted the fix-infer-local-app branch June 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app create does not work with local path (tries to infer application type by cloning)
2 participants