Prevent segfault with empty kustomization #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ongy
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
I'm not entirely sure when this happens, but the kustomize can be nil. Accessing Images then leads to a nil-deref. With this approach, the updater defaults to empty images when it cannot get the real ones. Signed-off-by: Markus Ongyerth <[email protected]>
Ongy
force-pushed
the
dont-access-nil-kustomize
branch
from
a019603 to
2fd1703
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 63.26% 63.27% +0.01%
==========================================
Files 15 15
Lines 2243 2252 +9
==========================================
+ Hits 1419 1425 +6
- Misses 733 735 +2
- Partials 91 92 +1 ☔ View full report in Codecov by Sentry. |
chengfang
approved these changes
Feb 4, 2025
|
@Ongy thanks for the fix. Can you please fix the DCO check failure by adding git sign-off? |
|
I already added Though it might also be unhappy because that's not the same email as in the commit itself. I'll update that later today and see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure when this happens, but the kustomize can be nil. Accessing Images then leads to a nil-deref.
With this approach, the updater defaults to empty images when it cannot get the real ones.