Update release process to create a separate tag for registry-scanner #1022
Conversation
ishitasequeira
changed the title
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
force-pushed
the
update-release-script
branch
from
57a8807 to
c6ac26a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 63.26% 63.26%
=======================================
Files 15 15
Lines 2243 2243
=======================================
Hits 1419 1419
Misses 733 733
Partials 91 91 ☔ View full report in Codecov by Sentry. |
ishitasequeira
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
|
I personally prefer to have the release files contained under registry-scanner itself. I guess pretty soon these 2 will diverge in versions. Then for image-updater, registry-scanner is just another dependency to manage. |
| go mod download && go mod tidy | ||
|
|
||
| # Commit and push the changes | ||
| git commit -m "Release ${NEW_VERSION}" VERSION go.mod go.sum manifests/ | ||
| git push --set-upstream ${REMOTE} "feat/new-version-${NEW_VERSION}" |
There was a problem hiding this comment.
do we need git add before commit?
| git commit -m "Release ${NEW_VERSION}" VERSION manifests/ | ||
|
|
||
| # Create tag for registry-scanner | ||
| git tag -a ${IMAGE_TAG} -m "Registry-Scanner Release ${IMAGE_TAG}" |
There was a problem hiding this comment.
I remember reading somewhere that tagging a sub-module needs to have the sub-module name as prefix, something like registry-scanner/v0.16.0 as the tag name. Otherwise, one can't tell if this tag is for the main module, or any sub-module.
Update release process to create a separate tag for registry-scanner.
Currently, keeping the release version of registry-scanner same as image updater. Let me know if we need to change this version matching for image-updater and registry-scanner.