Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): support application in any namespace with argocd app diff(#13978) #13980

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix(cli): support application in any namespace with argocd app diff(#13978) #13980

merged 1 commit into from
Jun 14, 2023

Conversation

mugioka
Copy link
Contributor

@mugioka mugioka commented Jun 9, 2023 •
edited
Loading

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Closes #13978.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (330252d) 49.56% compared to head (97533e8) 49.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #13980   +/-   ##
=======================================
  Coverage   49.56%   49.57%           
=======================================
  Files         256      256           
  Lines       43920    43920           
=======================================
+ Hits        21770    21773    +3     
+ Misses      19987    19985    -2     
+ Partials     2163     2162    -1
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 21.80% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

todaywasawesome
todaywasawesome approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature, good work!

@mugioka mugioka changed the title feat: support application in any namespace with argocd app diff. feat: support application in any namespace with argocd app diff(#13978). Jun 10, 2023
@mugioka
Copy link
Contributor Author

mugioka commented Jun 12, 2023

@crenshaw-dev pull request is ready for review now

ishitasequeira
ishitasequeira approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@crenshaw-dev crenshaw-dev changed the title feat: support application in any namespace with argocd app diff(#13978). fix(cli): support application in any namespace with argocd app diff(#13978) Jun 14, 2023
@crenshaw-dev
Copy link
Member

crenshaw-dev commented Jun 14, 2023 •
edited
Loading

@mugioka do you have time to add an e2e test to avoid regressions?

@mugioka
Copy link
Contributor Author

mugioka commented Jun 14, 2023 •
edited
Loading

@crenshaw-dev ok, i will be try. should I addressed with this PR?
this issue is critical for me and i would like to merge it as soon as possible.

crenshaw-dev
crenshaw-dev approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up PR will be fine! Let's get this out with tomorrow's patch.

@crenshaw-dev crenshaw-dev merged commit 495d093 into argoproj:master Jun 14, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 14, 2023
@mugioka
fix(cli): support application in any namespace with argocd app diff (…
5d1cec7 
…#13978) (#13980)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 14, 2023
Merged
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.5

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 14, 2023
@mugioka
fix(cli): support application in any namespace with argocd app diff (…
21a886a 
…#13978) (#13980)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 14, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 14, 2023
@mugioka
fix(cli): support application in any namespace with argocd app diff (…
d1bcdb5 
…#13978) (#13980)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 14, 2023
Merged
crenshaw-dev pushed a commit that referenced this pull request Jun 14, 2023
@gcp-cherry-pick-bot @mugioka
fix(cli): support application in any namespace with argocd app diff (…
cbed3d4 
…#13978) (#13980) (#14061)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
Co-authored-by: mugi <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Jun 14, 2023
@gcp-cherry-pick-bot @mugioka
fix(cli): support application in any namespace with argocd app diff (…
d62b037 
…#13978) (#13980) (#14063)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
Co-authored-by: mugi <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Jun 14, 2023
@gcp-cherry-pick-bot @mugioka
fix(cli): support application in any namespace with argocd app diff (…
9aaade6 
…#13978) (#13980) (#14062)

Closes #13978.

Signed-off-by: mugioka <[email protected]>
Co-authored-by: mugi <[email protected]>
@maxbrunet maxbrunet mentioned this pull request Jun 14, 2023
Merged
13 tasks
@mugioka mugioka deleted the feat/support-app-in-any-ns-with-app-diff branch June 15, 2023 01:16
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @mugioka @schakrad
fix(cli): support application in any namespace with argocd app diff (…
9ede506 
…argoproj#13978) (argoproj#13980) (argoproj#14061)

Closes argoproj#13978.

Signed-off-by: mugioka <[email protected]>
Co-authored-by: mugi <[email protected]>
Signed-off-by: schakrad <[email protected]>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@mugioka
fix(cli): support application in any namespace with argocd app diff (…
46e1a6f 
…argoproj#13978) (argoproj#13980)

Closes argoproj#13978.

Signed-off-by: mugioka <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@mugioka @tesla59
fix(cli): support application in any namespace with argocd app diff (…
73cbdb2 
…argoproj#13978) (argoproj#13980)

Closes argoproj#13978.

Signed-off-by: mugioka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argocd app diff should support application in any namespace.
4 participants
@mugioka @crenshaw-dev @todaywasawesome @ishitasequeira