Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump ubuntu base image version #14024

Merged
merged 2 commits into from
Jun 14, 2023
Merged

chore(deps): bump ubuntu base image version #14024

merged 2 commits into from
Jun 14, 2023

Conversation

crenshaw-dev
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@crenshaw-dev crenshaw-dev requested a review from jmeridth June 13, 2023 20:22
@crenshaw-dev crenshaw-dev added the security Security related label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (f63b856) 49.57% compared to head (d1710db) 49.57%.

❗ Current head d1710db differs from pull request most recent head 15edeb2. Consider uploading reports for the commit 15edeb2 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14024   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         256      256           
  Lines       43920    43920           
=======================================
  Hits        21773    21773           
  Misses      19985    19985           
  Partials     2162     2162

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jannfis
jannfis approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis enabled auto-merge (squash) June 14, 2023 15:39
@jannfis jannfis merged commit bc9e7bd into argoproj:master Jun 14, 2023
@crenshaw-dev crenshaw-dev deleted the bump-ubuntu-image branch June 14, 2023 21:31
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.7

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 14, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 14, 2023
@crenshaw-dev
chore(deps): bump ubuntu base image version (#14024)
aac577c 
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit that referenced this pull request Jun 14, 2023
@gcp-cherry-pick-bot @crenshaw-dev
chore(deps): bump ubuntu base image version (#14024) (#14066)
d7f67a1 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @crenshaw-dev @schakrad
chore(deps): bump ubuntu base image version (argoproj#14024) (argopro…
c777890 
…j#14066)

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@crenshaw-dev
chore(deps): bump ubuntu base image version (argoproj#14024)
8351416 
Signed-off-by: Michael Crenshaw <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@crenshaw-dev @tesla59
chore(deps): bump ubuntu base image version (argoproj#14024)
85448e8 
Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crenshaw-dev @jmeridth @jannfis