Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded 'git' user in util/git.NewClient #1556

Merged
merged 1 commit into from
May 2, 2019
Merged

Fix hardcoded 'git' user in util/git.NewClient #1556

merged 1 commit into from
May 2, 2019

Conversation

pbrit
Copy link
Contributor

@pbrit pbrit commented May 2, 2019

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 2, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #1556 into master will increase coverage by 0.08%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   32.05%   32.14%   +0.08%     
==========================================
  Files          70       70              
  Lines       11173    11178       +5     
==========================================
+ Hits         3582     3593      +11     
+ Misses       7073     7061      -12     
- Partials      518      524       +6
Impacted Files Coverage Δ
reposerver/repository/repository.go 45.21% <100%> (ø) ⬆️
util/git/client.go 55.55% <50%> (-0.53%) ⬇️
controller/appcontroller.go 33.6% <0%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f268f82...874218e. Read the comment docs.

@alexmt alexmt mentioned this pull request May 2, 2019
Closed
@alexmt alexmt self-requested a review May 2, 2019 17:00
alexmt
alexmt approved these changes May 2, 2019
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit d06303c into argoproj:master May 2, 2019
alexmt pushed a commit that referenced this pull request May 9, 2019
@pbrit
Fix hardcoded 'git' user in util/git.NewClient (#1556)
e090857 
Closes #1555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbrit @CLAassistant @codecov-io @alexmt