Added --async flag to argocd app sync
#1738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
+ Coverage 34.2% 34.27% +0.06%
==========================================
Files 77 77
Lines 11444 11447 +3
==========================================
+ Hits 3914 3923 +9
+ Misses 6988 6978 -10
- Partials 542 546 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
- Coverage 34.2% 34.19% -0.01%
==========================================
Files 77 77
Lines 11444 11447 +3
==========================================
Hits 3914 3914
- Misses 6988 6991 +3
Partials 542 542
Continue to review full report at Codecov.
|
test/e2e/app_management_test.go
Outdated
| assert.NoError(t, err) | ||
| resources, err := kube.SplitYAML(manifests) | ||
| assert.NoError(t, err) | ||
| manipulateApplicationResources(t, app) |
There was a problem hiding this comment.
I actually don't think you should extract this func, I don't think you need it for your test. I'll explain why in my next comment.
| @@ -63,6 +63,10 @@ func (a *Actions) PatchApp(patch string) *Actions { | |||
| func (a *Actions) Sync() *Actions { | |||
| args := []string{"app", "sync", a.context.name, "--timeout", "5"} | |||
|
|
|||
| if a.context.async { | |||
| args = append(args, "--async") | |||
| } | |||
| res, _ = fixture.RunCli("app", "sync", app.Name, "--label", "this-label=does-not-exist") | ||
| _, _ = fixture.RunCli("app", "sync", app.Name, "--label", fmt.Sprintf("app.kubernetes.io/instance=%s", app.Name)) | ||
| }). | ||
| Expect(SyncStatusIs(SyncStatusCodeSynced)). |
#1728. Short and sweet: async sync! Includes test