fix: Override sub with federated_claims.user_id when dex is used

[aali309]

Fixes: #17908

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

Attention: Patch coverage is 61.60000% with 48 lines in your changes missing coverage. Please review.

Project coverage is 55.50%. Comparing base (6f5537b) to head (95f1e4e).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
util/session/sessionmanager.go	69.04%	10 Missing and 3 partials ⚠️
cmd/argocd/commands/project_role.go	0.00%	12 Missing ⚠️
server/server.go	31.25%	9 Missing and 2 partials ⚠️
cmd/argocd/commands/login.go	50.00%	5 Missing and 1 partial ⚠️
server/rbacpolicy/rbacpolicy.go	40.00%	2 Missing and 1 partial ⚠️
util/claims/claims.go	86.95%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20683      +/-   ##
==========================================
- Coverage   55.59%   55.50%   -0.09%     
==========================================
  Files         339      340       +1     
  Lines       57346    57417      +71     
==========================================
- Hits        31881    31870      -11     
- Misses      22784    22847      +63     
- Partials     2681     2700      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ishitasequeira]

Overall code change looks good!!

@jannfis @pasha-codefresh do you see any concerns with the change?

[agaudreault]

The change from RegisterClaims to MapClaims makes this PR a lot more impactful and the blast radius is hard to grasp, especially that not the same claims seems to be added in the context object.

[agaudreault]

Hey @aali309. Thanks for the changes. The logic look good. I will push some style refactor and changes to the unit tests so we can merge this in the next version 🚀 🎉