-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: argocd-cmd-params-cm yaml correction #21046
base: master
Are you sure you want to change the base?
Conversation
Correction to controller.self.heal.backoff.timeout.seconds Signed-off-by: Akhil Raj <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like both of these settings exist. I'm not sure how they differ.
- name: ARGOCD_APPLICATION_CONTROLLER_SELF_HEAL_TIMEOUT_SECONDS
valueFrom:
configMapKeyRef:
name: argocd-cmd-params-cm
key: controller.self.heal.timeout.seconds
optional: true
- name: ARGOCD_APPLICATION_CONTROLLER_SELF_HEAL_BACKOFF_TIMEOUT_SECONDS
valueFrom:
configMapKeyRef:
name: argocd-cmd-params-cm
key: controller.self.heal.backoff.timeout.seconds
optional: true
I would assume timeout is how long before a request times out and the backoff is how long it will wait before trying again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand from https://github.com/argoproj/argo-cd/blob/master/controller/appcontroller.go#L2137,
if selfHealBackOff is not configured, then the selfHealTimeout is used.
So both fields are relevant.
Maybe it is worth to highlight that in the documentation though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through @reggie-k comment to document it otherwise LGTM
@@ -48,7 +48,7 @@ data: | |||
# Prometheus metrics cache expiration (disabled by default. e.g. 24h0m0s) | |||
controller.metrics.cache.expiration: "24h0m0s" | |||
# Specifies exponential backoff timeout parameters between application self heal attempts | |||
controller.self.heal.timeout.seconds: "2" | |||
controller.self.heal.backoff.timeout.seconds: "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to test this?
This is an update to docs by adding exponential backoff timeout.
Correction to
controller.self.heal.backoff.timeout.seconds
Fixes #21021
Checklist: