Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): make Name column wider (argoproj#21080) #21375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ui): make Name column wider (argoproj#21080) #21375

wants to merge 2 commits into from
+4 −4

Conversation

korsar182
Copy link

Fixes #21080

@korsar182 korsar182 requested a review from a team as a code owner January 4, 2025 20:01
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 4, 2025 •
edited
Loading

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-ls7iio.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-ls7iio.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

reggie-k
reggie-k reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you add a screenshot of how it looks after the change?
And could you rename the chore in the PR name to fix(ui)?

@korsar182 korsar182 changed the title chore: make Name column wider (argoproj#21080) fix(ui): make Name column wider (argoproj#21080) Jan 6, 2025
@korsar182 korsar182 marked this pull request as draft January 6, 2025 14:25
@korsar182 korsar182 marked this pull request as ready for review January 6, 2025 16:59
@korsar182
Copy link
Author

After the change it looks like this. Not the best, but seems better, then current state
image

@Ant8500 Ant8500 mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie-k reggie-k reggie-k left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make "name" column wider
2 participants
@korsar182 @reggie-k