Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dex): always request federated:id scope (#17908) #21726

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

agaudreault
Copy link
Member

Fixes #17908

@agaudreault agaudreault requested a review from a team as a code owner January 31, 2025 02:01
Copy link

bunnyshell bot commented Jan 31, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault enabled auto-merge (squash) January 31, 2025 02:03
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.61%. Comparing base (85c6d26) to head (884f40b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/apiclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21726      +/-   ##
==========================================
- Coverage   53.65%   53.61%   -0.05%     
==========================================
  Files         340      340              
  Lines       57417    57419       +2     
==========================================
- Hits        30808    30784      -24     
- Misses      23956    23986      +30     
+ Partials     2653     2649       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner January 31, 2025 16:32
@crenshaw-dev crenshaw-dev disabled auto-merge January 31, 2025 16:33
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) January 31, 2025 16:34
Signed-off-by: Alexandre Gaudreault <[email protected]>
@crenshaw-dev crenshaw-dev merged commit b4a63ae into argoproj:master Jan 31, 2025
26 checks passed
@agaudreault agaudreault deleted the request-dex-scope branch January 31, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC using LDAP is not working (Not assigning the policies)
2 participants