Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use RLock and RUnlock for project to improve performance #6225

Merged
merged 2 commits into from
May 14, 2021
Merged

feat: use RLock and RUnlock for project to improve performance #6225

merged 2 commits into from
May 14, 2021

Conversation

yujunz
Copy link
Contributor

@yujunz yujunz commented May 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2021 •
edited
Loading

Codecov Report

Merging #6225 (cfef503) into master (9bf83b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6225   +/-   ##
=======================================
  Coverage   41.21%   41.21%           
=======================================
  Files         147      147           
  Lines       19862    19862           
=======================================
  Hits         8186     8186           
  Misses      10556    10556           
  Partials     1120     1120
Impacted Files Coverage Δ
server/application/application.go 30.91% <100.00%> (ø)
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf83b4...cfef503. Read the comment docs.

@yujunz yujunz marked this pull request as draft May 13, 2021 01:10
@yujunz yujunz force-pushed the rwlock branch 2 times, most recently from ec8f99c to f529483 Compare May 13, 2021 03:35
@yujunz yujunz marked this pull request as ready for review May 13, 2021 12:52
alexmt
alexmt approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit a1419c2 into argoproj:master May 14, 2021
@yujunz yujunz deleted the rwlock branch May 14, 2021 02:59
alexmt pushed a commit that referenced this pull request Jun 4, 2021
@yujunz @alexmt
feat: use RLock and RUnlock for project to improve performance (#6225)
3a95e8f 
* feat: use RLock and RUnlock for project to improve performance

Signed-off-by: Yujun Zhang <[email protected]>

* chore: go mod vendor && go mod tidy

Signed-off-by: Yujun Zhang <[email protected]>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees

@alexmt alexmt

Labels
needs-verification PR requires pre-release verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujunz @alexmt @jannfis