-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update documentation Argocd app CRD health with app of apps #6281
Conversation
Signed-off-by: LucasBoisserie <[email protected]>
Signed-off-by: LucasBoisserie <[email protected]>
Signed-off-by: LucasBoisserie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6281 +/- ##
==========================================
- Coverage 41.10% 40.92% -0.18%
==========================================
Files 151 152 +1
Lines 19934 20044 +110
==========================================
+ Hits 8193 8203 +10
- Misses 10612 10715 +103
+ Partials 1129 1126 -3
Continue to review full report at Codecov.
|
@@ -27,12 +27,14 @@ data: | |||
argoproj.io/Application: | |||
health.lua: | | |||
hs = {} | |||
hs.status = "Healthy" | |||
hs.status = "Progressing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 how could I miss it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still not working with me even after changing the status to Progressing, is there any other configurations I need to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @LucasBoisserie and @ymmt2005 !
I spent so much time trying to understand why app of apps is not working. Very appreciate your fix.
fix: Update documentation Argocd app CRD health with app of apps (#6281) Signed-off-by: LucasBoisserie <[email protected]>
sorry, ignore (posted in wrong window and can't delete comment) |
ref #5146, #5423
I also add argocd app crd health to health documentation to facilitate information search
Checklist: