Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update documentation Argocd app CRD health with app of apps #6281

Merged
merged 3 commits into from
Jun 3, 2021
Merged

fix: Update documentation Argocd app CRD health with app of apps #6281

merged 3 commits into from
Jun 3, 2021

Conversation

LucasBoisserie
Copy link
Contributor

@LucasBoisserie LucasBoisserie commented May 20, 2021

ref #5146, #5423

I also add argocd app crd health to health documentation to facilitate information search

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@LucasBoisserie LucasBoisserie changed the title Update documentation Argocd app CRD health with app of apps fix: Update documentation Argocd app CRD health with app of apps May 20, 2021
Signed-off-by: LucasBoisserie <[email protected]>
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #6281 (d8882ed) into master (40629e5) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6281      +/-   ##
==========================================
- Coverage   41.10%   40.92%   -0.18%     
==========================================
  Files         151      152       +1     
  Lines       19934    20044     +110     
==========================================
+ Hits         8193     8203      +10     
- Misses      10612    10715     +103     
+ Partials     1129     1126       -3     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 58.07% <0.00%> (-0.64%) ⬇️
server/server.go 54.87% <0.00%> (-0.61%) ⬇️
controller/sync.go 64.66% <0.00%> (-0.23%) ⬇️
util/git/client.go 44.28% <0.00%> (-0.16%) ⬇️
controller/appcontroller.go 53.05% <0.00%> (-0.10%) ⬇️
util/exec/exec.go 100.00% <0.00%> (ø)
util/kube/kubectl.go 0.00% <0.00%> (ø)
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)
util/session/sessionmanager.go 70.11% <0.00%> (ø)
cmd/argocd-util/commands/cluster.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40629e5...d8882ed. Read the comment docs.

@@ -27,12 +27,14 @@ data:
argoproj.io/Application:
health.lua: |
hs = {}
hs.status = "Healthy"
hs.status = "Progressing"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 how could I miss it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still not working with me even after changing the status to Progressing, is there any other configurations I need to update?

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @LucasBoisserie and @ymmt2005 !

I spent so much time trying to understand why app of apps is not working. Very appreciate your fix.

@alexmt alexmt merged commit bffdd0b into argoproj:master Jun 3, 2021
@LucasBoisserie LucasBoisserie deleted the argocd_app_health branch June 3, 2021 18:13
alexmt pushed a commit that referenced this pull request Jun 4, 2021
fix: Update documentation Argocd app CRD health with app of apps (#6281)

Signed-off-by: LucasBoisserie <[email protected]>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@karlschriek
Copy link

karlschriek commented Jul 28, 2022

sorry, ignore (posted in wrong window and can't delete comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants