Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Golang to v1.16.4 #6358

Merged
merged 1 commit into from
May 28, 2021

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented May 28, 2021

Update the Go version we use to build Argo CD to v1.16.4 due to a security fix in net/http (see CVE-2021-31525)

Candidate for cherry-pick to 2.0 branch. 1.8 is still on 1.14 and is not affected to this issue according to the CVE.

Signed-off-by: jannfis [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jannfis jannfis added cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch and removed cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch labels May 28, 2021
@jannfis jannfis requested review from alexmt, jgwest and kshamajain99 May 28, 2021 15:41
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #6358 (5418bdd) into master (1708a71) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6358   +/-   ##
=======================================
  Coverage   40.90%   40.91%           
=======================================
  Files         151      151           
  Lines       20020    20021    +1     
=======================================
+ Hits         8189     8191    +2     
  Misses      10704    10704           
+ Partials     1127     1126    -1     
Impacted Files Coverage Δ
controller/sync.go 64.66% <0.00%> (-0.49%) ⬇️
util/settings/settings.go 47.03% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1708a71...5418bdd. Read the comment docs.

@jannfis jannfis merged commit 4a3c94b into argoproj:master May 28, 2021
jannfis added a commit that referenced this pull request Jun 1, 2021
@jannfis
Copy link
Member Author

jannfis commented Jun 1, 2021

Change has been cherry-picked to 2.0: 959f675

alexmt added a commit that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants