Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Crash on application pod view #6384

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jun 2, 2021

Fixes #6381

Signed-off-by: Remington Breeze [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@rbreeze rbreeze requested a review from alexmt June 2, 2021 20:05
Signed-off-by: Remington Breeze <[email protected]>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexmt alexmt added the cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch label Jun 2, 2021
@alexmt
Copy link
Collaborator

alexmt commented Jun 2, 2021

Cherry-picking fix to release-2.0 once PR is merged.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #6384 (a9566df) into master (3fbe818) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6384   +/-   ##
=======================================
  Coverage   40.92%   40.92%           
=======================================
  Files         152      152           
  Lines       20044    20044           
=======================================
  Hits         8203     8203           
  Misses      10715    10715           
  Partials     1126     1126           
Impacted Files Coverage Δ
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbe818...a9566df. Read the comment docs.

@rbreeze rbreeze merged commit f43a6ad into argoproj:master Jun 2, 2021
@rbreeze rbreeze deleted the app-crash branch June 2, 2021 21:19
alexmt pushed a commit that referenced this pull request Jun 4, 2021
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@rbreeze
Copy link
Member Author

rbreeze commented Jul 29, 2021

Addendum #6858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something went wrong!
2 participants