fix: add client side retry to prevent 'transport is closing' errors #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
transport-closing-error
branch
2 times, most recently
from
bd9b324 to
da94121
Compare
jessesuen
approved these changes
Jun 4, 2021
mayzhang2000
approved these changes
Jun 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #6402 +/- ##
==========================================
+ Coverage 41.00% 41.01% +0.01%
==========================================
Files 152 152
Lines 20081 20088 +7
==========================================
+ Hits 8234 8239 +5
- Misses 10715 10716 +1
- Partials 1132 1133 +1
Continue to review full report at Codecov.
|
Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
transport-closing-error
branch
from
da94121 to
313ad5d
Compare
alexmt
changed the title
alexmt
pushed a commit
that referenced
this pull request
Jun 4, 2021
…6402) Signed-off-by: Alexander Matyushentsev <[email protected]>
mcanevet
added a commit
to mcanevet/devops-stack
that referenced
this pull request
Jun 23, 2021
Note: thanks to argoproj/argo-cd#6402, it's not required anymore to retry.
mcanevet
added a commit
to mcanevet/devops-stack
that referenced
this pull request
Aug 11, 2021
Note: thanks to argoproj/argo-cd#6402, it's not required anymore to retry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev [email protected]
We are periodically seeing 'transport is closing' errors from
argocdCLI in production. The reason is that Argo CD API server runs behind load balancer but uses default ( infinite ) idle connection timeout. Load balancer periodically closes idle connections which causes the error. PR adds retry to client side as well as changes max idle connection timeout to 5 mins (configurable via env variable).