Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows access to dex metrics from any pod #6420

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 7, 2021

Signed-off-by: Alexander Matyushentsev [email protected]

Closes: #6407

Dex exposes metrics on port 5558. Opening it by default to any pod

Signed-off-by: Alexander Matyushentsev <[email protected]>
@alexmt alexmt requested a review from jannfis June 7, 2021 16:55
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #6420 (6f5e5d3) into master (e44fa43) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6420      +/-   ##
==========================================
+ Coverage   40.91%   41.01%   +0.09%     
==========================================
  Files         152      152              
  Lines       20044    20088      +44     
==========================================
+ Hits         8201     8239      +38     
  Misses      10716    10716              
- Partials     1127     1133       +6     
Impacted Files Coverage Δ
util/argo/normalizers/diff_normalizer.go 76.47% <0.00%> (-0.81%) ⬇️
pkg/apis/application/v1alpha1/types.go 58.07% <0.00%> (ø)
reposerver/repository/repository.go 60.85% <0.00%> (+0.09%) ⬆️
controller/appcontroller.go 53.27% <0.00%> (+0.22%) ⬆️
util/helm/cmd.go 29.81% <0.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44fa43...6f5e5d3. Read the comment docs.

@alexmt alexmt merged commit 33d691e into argoproj:master Jun 7, 2021
@alexmt alexmt deleted the 6407-dex-metrics-policy branch June 7, 2021 17:42
alexmt pushed a commit that referenced this pull request Jun 7, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly added NetworkPolicy prevents dex server metrics from being scraped
2 participants