Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin mkdocs version to fix docs build #6421

Merged
merged 1 commit into from
Jun 7, 2021
Merged

chore: pin mkdocs version to fix docs build #6421

merged 1 commit into from
Jun 7, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 7, 2021

Signed-off-by: Alexander Matyushentsev [email protected]

@alexmt alexmt requested a review from jannfis June 7, 2021 17:09
jannfis
jannfis approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt
chore: pin mkdocs version to fix docs build
3da0b55 
Signed-off-by: Alexander Matyushentsev <[email protected]>
@codecov
Copy link

codecov bot commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #6421 (3da0b55) into master (f2093ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6421   +/-   ##
=======================================
  Coverage   41.01%   41.01%           
=======================================
  Files         152      152           
  Lines       20088    20088           
=======================================
  Hits         8239     8239           
  Misses      10716    10716           
  Partials     1133     1133
Impacted Files Coverage Δ
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2093ec...3da0b55. Read the comment docs.

@alexmt alexmt merged commit 124cc8a into argoproj:master Jun 7, 2021
@alexmt alexmt deleted the fix-docs-build branch June 7, 2021 17:53
alexmt pushed a commit that referenced this pull request Jun 7, 2021
@alexmt
chore: pin mkdocs version to fix docs build (#6421)
f42c305 
Signed-off-by: Alexander Matyushentsev <[email protected]>
@ryota-sakamoto ryota-sakamoto mentioned this pull request Jul 4, 2021
Merged
@jannfis jannfis added cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch labels Jul 11, 2021
@jannfis
Copy link
Member

jannfis commented Jul 11, 2021

Also going to cherry-pick into 1.8 branch.

jannfis pushed a commit that referenced this pull request Jul 11, 2021
@jannfis
chore: pin mkdocs version to fix docs build (#6421)
ebbc1d0 
Signed-off-by: Alexander Matyushentsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
cherry-pick/1.8 Candidate for cherry picking into the 1.8 release branch cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmt @jannfis