Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in networkPolicy definition in manifests #6532

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix: typo in networkPolicy definition in manifests #6532

merged 1 commit into from
Jun 22, 2021

Conversation

antoninbas
Copy link
Contributor

Unless the argocd-dex-server-network-policy NetworkPolicy was meant to
authorize ALL TCP traffic, which seems unlikely, this is a typo.

Signed-off-by: Antonin Bas [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@antoninbas
fix: typo in networkPolicy definition in manifests
79f6630 
Unless the argocd-dex-server-network-policy NetworkPolicy was meant to
authorize ALL TCP traffic, which seems unlikely, this is a typo.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas antoninbas force-pushed the fix-possible-typo-in-install-manifest branch from 887f35f to 79f6630 Compare June 22, 2021 21:29
@antoninbas antoninbas changed the title Fix typo in networkPolicy definition in manifests fix: typo in networkPolicy definition in manifests Jun 22, 2021
alexmt
alexmt approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks a lot for catching it!

@alexmt alexmt merged commit 4ae5cdf into argoproj:master Jun 22, 2021
alexmt pushed a commit that referenced this pull request Jun 22, 2021
@antoninbas @alexmt
fix: typo in networkPolicy definition in manifests (#6532)
ae1401c 
Unless the argocd-dex-server-network-policy NetworkPolicy was meant to
authorize ALL TCP traffic, which seems unlikely, this is a typo.

Signed-off-by: Antonin Bas <[email protected]>
@alexmt
Copy link
Collaborator

alexmt commented Jun 22, 2021

cherry-picked the fix into release-2.0

@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees

@alexmt alexmt

Labels
needs-verification PR requires pre-release verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoninbas @alexmt @jannfis