fix: added controller config validation (#2103)

* fix: make webhook url optional

Signed-off-by: Daniel Soifer <[email protected]>

controllers/cmd/start.go

@@ -34,11 +34,16 @@ const (
 func Start(namespaced bool, managedNamespace string) {
 	logger := logging.NewArgoEventsLogger().Named(eventbus.ControllerName)
 	config, err := controllers.LoadConfig(func(err error) {
-		logger.Errorf("Failed to reload global configuration file", zap.Error(err))
+		logger.Errorw("Failed to reload global configuration file", zap.Error(err))
 	})
 	if err != nil {
 		logger.Fatalw("Failed to load global configuration file", zap.Error(err))
 	}
+
+	if err = controllers.ValidateConfig(config); err != nil {
+		logger.Fatalw("Global configuration file validation failed", zap.Error(err))
+	}
+
 	imageName, defined := os.LookupEnv(imageEnvVar)
 	if !defined {
 		logger.Fatalf("required environment variable '%s' not defined", imageEnvVar)

controllers/config.go

@@ -116,3 +116,15 @@ func LoadConfig(onErrorReloading func(error)) (*GlobalConfig, error) {
 	})
 	return r, nil
 }
+
+func ValidateConfig(config *GlobalConfig) error {
+	if len(config.supportedJetStreamVersions()) == 0 {
+		return fmt.Errorf("no jetstream versions were provided in the controller config")
+	}
+
+	if len(config.supportedSTANVersions()) == 0 {
+		return fmt.Errorf("no stan versions were provided in the controller config")
+	}
+
+	return nil
+}