Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete functionality for k8s trigger #1040

Closed
tinkerborg opened this issue Jan 27, 2021 · 0 comments · Fixed by #1041
Closed

Delete functionality for k8s trigger #1040

tinkerborg opened this issue Jan 27, 2021 · 0 comments · Fixed by #1041
Labels
enhancement New feature or request
Milestone
v1.3

Comments

@tinkerborg
Copy link
Contributor

tinkerborg commented Jan 27, 2021 •
edited
Loading

Currently the standard k8s trigger does not support delete operations.

I would like to be able to use this for things like creating an argo-cd Application object when a pull request is opened in Github, and deleting the object when the associated PR is closed.

As an alternative, I could trigger a job but this would be a much cleaner approach.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
@tinkerborg tinkerborg added the enhancement New feature or request label Jan 27, 2021
@tinkerborg tinkerborg mentioned this issue Jan 27, 2021
Merged
whynowy pushed a commit that referenced this issue Jan 29, 2021
@tinkerborg
feat: implement delete function for k8s objects (#1041)
706b746 
* feat: implement delete function for k8s objects

This implements `delete` functionality for the standard-k8s trigger.

resolves #1040
fixes #638

Signed-off-by: tinkerborg <[email protected]>
@whynowy whynowy added this to the v1.3 milestone Jan 29, 2021
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
@tinkerborg
feat: implement delete function for k8s objects (argoproj#1041)
5452769 
* feat: implement delete function for k8s objects

This implements `delete` functionality for the standard-k8s trigger.

resolves argoproj#1040
fixes argoproj#638

Signed-off-by: tinkerborg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

feat: implement delete function for k8s objects
2 participants
@whynowy @tinkerborg