Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get version, kind and resource from the spec when creating k8s/workflows #1143

Closed
whynowy opened this issue Mar 30, 2021 · 1 comment
Closed
Labels
enhancement New feature or request
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Mar 30, 2021

Is your feature request related to a problem? Please describe.
When creating k8s or argoWorkflow resources in the Sensor, version, kind and resource are required, which seem to be redundant.

Describe the solution you'd like
The sensor should be able to figure out those properties automatically from the provided k8s object or workflow spec.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@daniel-codefresh
Copy link
Member

Hey @whynowy, heres the PR :) #1333

@whynowy whynowy closed this as completed Sep 14, 2021
@whynowy whynowy added this to the v1.5 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants