Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed usage of redundant GVR fields in k8s/workflow triggers #1333

Merged

Conversation

daniel-codefresh
Copy link
Member

@daniel-codefresh daniel-codefresh commented Sep 3, 2021

Signed-off-by: Daniel Soifer [email protected]

Checklist:

@daniel-codefresh
Copy link
Member Author

Solves #1143

Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@VaibhavPage VaibhavPage merged commit 24ef7c6 into argoproj:master Sep 5, 2021
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
…rgoproj#1333)

* removed usage of redundent group,version,resource fields in k8s/workflow triggers

Signed-off-by: Daniel Soifer <[email protected]>

* fix

Signed-off-by: Daniel Soifer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants