Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Amazon SNS, SQS and GCP Pub Sub gateway #154

Closed
VaibhavPage opened this issue Jan 17, 2019 · 5 comments
Closed

Rewrite Amazon SNS, SQS and GCP Pub Sub gateway #154

VaibhavPage opened this issue Jan 17, 2019 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.8.1

Comments

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Jan 17, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
The implementation of these gateways are stale and need to refactor some code due to #147

Existing implementation https://github.com/argoproj/argo-events/tree/amazon-sns-gateway
@VaibhavPage VaibhavPage added the good first issue Good for newcomers label Jan 17, 2019
@VaibhavPage VaibhavPage added the help wanted Extra attention is needed label Jan 30, 2019
@creatorrr
Copy link

Is PR #100 still active?

#100 (comment)

@VaibhavPage
Copy link
Contributor Author

No. that PR isn't active. Its just there for reference. The gateway architecture and couple other things got refactored which rendered the work on PR stale. If you want to contribute, have a stab at it.

@VaibhavPage VaibhavPage mentioned this issue Feb 16, 2019
Merged
@magaldima
Copy link
Contributor

#169 was merged to master and includes the AWS SNS gateway. I wanna try and tackle the GCP pub sub gateway..

@VaibhavPage
Copy link
Contributor Author

I will implement SQS gateway.

@VaibhavPage VaibhavPage added this to the v0.8.1 milestone Feb 28, 2019
@magaldima magaldima added enhancement New feature or request and removed help wanted Extra attention is needed labels Feb 28, 2019
@VaibhavPage
Copy link
Contributor Author

#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.8.1
Development

No branches or pull requests
3 participants
@creatorrr @VaibhavPage @magaldima